Issue filtering for get-pdfs-of-issues.py#2
Open
willnewton wants to merge 2 commits intomhl:masterfrom
Open
Conversation
| continue | ||
|
|
||
| if label: | ||
| found = False |
Owner
There was a problem hiding this comment.
I think this can be reduced to:
if not any(l['name'] == label for l in issue['labels']):
continue
Owner
|
Thanks very much for the pull request! This all looks useful - I left a small comment where I think the label code could be simplified. My only other thought was that it might be nice to use the API for fetching an issue label and a milestone to check that the user's supplied a label / milestone that actually exists before iterating over all the issues. I'm happy to merge this without that, though, if you don't think that's worth changing this PR for :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few options to get-pdfs-of-issues.py to filter what issues are handled and how much data is printed.